Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TAP for ESO module #3141

Draft
wants to merge 75 commits into
base: main
Choose a base branch
from
Draft

Enable TAP for ESO module #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
0ad006d
Switch to TAP list_surveys and list_instruments
juanmcloaiza Nov 27, 2024
ea9162b
Define tap_url as static method
juanmcloaiza Nov 27, 2024
cda3ad9
Deselect ALMA at query level - TEMPORAL SOLUTION
juanmcloaiza Nov 27, 2024
ba6ba41
Mark list_surveys as deprecated; define list_collections
juanmcloaiza Nov 27, 2024
e882d8c
Add name of the new function to deprecation warning
juanmcloaiza Nov 27, 2024
93e253f
Deprecate list_ and query_ _surveys in favor of _collections
juanmcloaiza Nov 27, 2024
b362552
Replace 'survey' by 'collection' accross eso module
juanmcloaiza Nov 28, 2024
105c8cf
Make Pep8-compliant
juanmcloaiza Nov 29, 2024
91c98e1
Use astroquery deprecated decorator
juanmcloaiza Nov 29, 2024
d0e9310
Accept argument 'surveys=' when calling *_surveys() deprecated functions
juanmcloaiza Nov 29, 2024
55657b0
Remove unused imports
juanmcloaiza Nov 29, 2024
90646e1
query_surveys --> query_collections in test_eso.py
juanmcloaiza Nov 29, 2024
0f099ce
Update CHANGES.rst
juanmcloaiza Nov 29, 2024
7098338
Add test_tap_url()
juanmcloaiza Nov 29, 2024
4a09d75
Remove hard-coded queries iside user-exposed functions
juanmcloaiza Dec 2, 2024
97a4ad5
Remove function _activate_form
juanmcloaiza Dec 2, 2024
851ee40
Develop py2adql function with tests
juanmcloaiza Dec 3, 2024
474c3bd
Handle coord1 and coord2 arguments in query_collections
juanmcloaiza Dec 4, 2024
e57f057
Remove intersects arg from py2adql
juanmcloaiza Dec 4, 2024
4060369
Write TAP enabled query_collections; pass existing tests
juanmcloaiza Dec 5, 2024
ecbd1f2
Remove intersects arg from py2adql test - not its responsibility
juanmcloaiza Dec 5, 2024
9abf461
Add ATLASGAL to SGRA_COLLECTIONS
juanmcloaiza Dec 5, 2024
cc51bc6
Ignore DALOverflowWarning thrown on truncated long query results
juanmcloaiza Dec 5, 2024
883f349
Write test for func query_tap_service
juanmcloaiza Dec 5, 2024
2ccb253
Define and use _query_tap_service
juanmcloaiza Dec 5, 2024
68ed74e
fwd query_instrument and _collections to query_instrument_or_collection
juanmcloaiza Dec 5, 2024
b66d987
Ignore DALOverflowWarning with more granularity
juanmcloaiza Dec 5, 2024
c790eee
Remove unused code
juanmcloaiza Dec 5, 2024
52cbe50
Take instrument or collection data from the corresponding table
juanmcloaiza Dec 6, 2024
280927a
Ignore DALOverflowWarning on remote tests
juanmcloaiza Dec 6, 2024
0a3e9f1
Issue queries based on new QueryOnField class
juanmcloaiza Dec 6, 2024
1e5c188
Remove unused function _query
juanmcloaiza Dec 9, 2024
596b11c
Modify test_multicollection to something less arbitrary
juanmcloaiza Dec 9, 2024
fa89ba2
Make PEP8 linter happy
juanmcloaiza Dec 9, 2024
9b629e9
Replace mutable default arguments by None
juanmcloaiza Dec 11, 2024
95bdd20
Add type hints to query_instruments and query_collections
juanmcloaiza Dec 11, 2024
6a7de6c
Rename *_list attributes; add return types
juanmcloaiza Dec 11, 2024
daf45fb
Add return types
juanmcloaiza Dec 11, 2024
93c9e64
Refactor QueryOnField classes as dataclasses
juanmcloaiza Dec 11, 2024
823a18a
correctly pass the dataclass to query_* function
juanmcloaiza Dec 11, 2024
602743d
Annotate types of EsoClass.collections and instruments
juanmcloaiza Dec 11, 2024
a06e6bb
Add type hints to py2adql
juanmcloaiza Dec 11, 2024
6f4ad2f
Write utils function sanitize_val; Add top arg in py2adql
juanmcloaiza Dec 11, 2024
455f38a
Write TAP version of query_main; sanitize constraints vals
juanmcloaiza Dec 11, 2024
919b411
correct typo in query string
juanmcloaiza Dec 12, 2024
0f1768e
Add test_main_SgrAstar
juanmcloaiza Dec 12, 2024
b3bdfbc
Row limit handled at query level. No filterwarnings needed
juanmcloaiza Dec 12, 2024
6033a35
query_main is always against dbo.raw
juanmcloaiza Dec 12, 2024
a75deb0
Add assert messages
juanmcloaiza Dec 12, 2024
a7b2b8f
Make linter happy
juanmcloaiza Dec 12, 2024
e91483e
Add cache functionality to tap queries
juanmcloaiza Dec 13, 2024
538f3c3
Try mimicking the old warning behaviour
juanmcloaiza Dec 13, 2024
a74edfb
Provisional fix to apex query
juanmcloaiza Dec 13, 2024
28e397b
Use t1.values_equal(t2) for table equality
juanmcloaiza Dec 13, 2024
0a90e34
Test table equality via t1.values_equal(t2)
juanmcloaiza Dec 16, 2024
ea39d2c
Do not exclude ALMA from collection queries
juanmcloaiza Dec 16, 2024
50d73ab
Rename request --> table in function from_cache(...)
juanmcloaiza Jan 16, 2025
db0b2a3
Remove unused data files
juanmcloaiza Jan 17, 2025
1279c68
Update monkeypatches in test_eso.py
juanmcloaiza Jan 17, 2025
5324fab
Add data needed by monkeypatch
juanmcloaiza Jan 17, 2025
f6c44a1
Cleanup test_eso.py
juanmcloaiza Jan 17, 2025
6f3bcdc
Make linter heppier
juanmcloaiza Jan 17, 2025
bfcea7a
Make the linter happier
juanmcloaiza Jan 17, 2025
c923d3b
Add docstrings to utils.py
juanmcloaiza Jan 17, 2025
42ec5e8
Make linter happy
juanmcloaiza Jan 17, 2025
1829e1c
Make linter happy
juanmcloaiza Jan 17, 2025
a36ea3d
Fix E502 the backslash is redundant between brackets
juanmcloaiza Jan 17, 2025
c19e7a6
Add changelog; fix docs title underline
juanmcloaiza Jan 17, 2025
c544979
Raise NotImplementedError in query_apex_quicklooks
juanmcloaiza Jan 17, 2025
4295805
Write monkeypatch offline test for apex_quicklooks
juanmcloaiza Jan 17, 2025
236734a
Write monkeypatch offline test for apex_quicklooks
juanmcloaiza Jan 17, 2025
ec84423
Addressed some TODOs
juanmcloaiza Jan 17, 2025
bfd6a86
Bugfix: The print_help message is truncated
juanmcloaiza Jan 31, 2025
68fde81
put back except Exception
juanmcloaiza Jan 31, 2025
b0546b6
Deprecate help arg in favour of print_help
juanmcloaiza Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ esasky

- Added support for eROSITA downloads. [#3111]

eso
^^^

- Deprecate functions ``list_surveys`` and ``query_surveys`` in favor of ``list_collections`` and ``query_collections``. [#3138]

- Use TAP backend instead of WDB. [#3141]

gaia
^^^^

Expand Down
Loading
Loading