Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some aliases for Vera C. Rubin Observatory telescopes #147

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

timj
Copy link
Contributor

@timj timj commented Nov 22, 2024

Following on from #139 add some aliases for Simonyi Survey Telescope and Rubin Auxiliary Telescope.

Fixes #139

]
},
"rubin_aux": {
"rubin_auxtel": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to not change the primary key? It's a list of observatories or telescopes, so the fact that it's a "tel" is implied, I think. We can have as many aliases as make sense, but we shouldn't change the primary key unless it's absolutely necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Reverted. I changed it because no-one at Rubin calls it this and everyone calls it auxtel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably you want me to revert the rubin -> rubin_simonyi key change as well then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that would be nice. People think of the "Rubin" as the main telescope of the observatory. That's probably not correct, but so common, that it might be OK to keep that as key. People using this from astropy as intended won't know the difference (if it's an alias they are searching for or the main key), but it's a public json file and we don't know who else uses it for what purpose, so better to be careful.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@timj timj force-pushed the u/timj/add-simonyi branch from 713d41e to ed13787 Compare November 23, 2024 01:31
This includes the standardized AAS Facility keywords as aliases.
@timj timj force-pushed the u/timj/add-simonyi branch from ed13787 to 828c713 Compare November 24, 2024 17:16
Copy link
Member

@hamogu hamogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. This database works because people like you put the correct information in one-by-one. It's not perfect, but getting better every time. Thanks!

@hamogu hamogu merged commit 3207d01 into astropy:gh-pages Nov 24, 2024
2 checks passed
@gpdf
Copy link

gpdf commented Dec 20, 2024

I'm uncomfortable with how this ended up. There is a canonical name, and that name is used in the AAS and will be used throughout IVOA services, the IVOA Registry, and a number of other places like publications databases. I certainly support having informal aliases to make it easier for people to find without knowing the exact formal spelling, but the data model should be that the aliases are linked to the canonical name, so that the canonical name can be looked up and then used to perform searches on other services.

@hamogu
Copy link
Member

hamogu commented Dec 20, 2024

Well, @gpdf, how would you like it to be then? If you feel strongly, as a Rubin insider, that the names should be listed in some specific way, I am happy to do that. I said "we shouldn't change the primary key unless absolutely necessary" and nobody above argued that it gets to the level of "necessary".

We don't want to potentially break backwards compatibility unless there is a very good reason - but if there is a very good reason like the one you laid out, we can do that.
So the question is: Are you just "uncomfortable" as in "unhappy" or are you "uncomfortable" as in "this will lead to all sorts of problems going forward"?

@timj
Copy link
Contributor Author

timj commented Dec 20, 2024

I picked the actual telescope name as the name because it's the name of the telescope and this file doesn't even seem to try to use the AAS facility names. I did add the AAS name as an alias but I felt that it didn't make sense as the primary name if we weren't using the AAS names consistently.

@pllim
Copy link
Member

pllim commented Dec 20, 2024

will be used throughout IVOA services, the IVOA Registry

Should this be discussed with PyVO or astroquery developers, as they are most likely to be impacted as well?

@bsipocz
Copy link
Member

bsipocz commented Dec 20, 2024

This is 100% user-facing rather than affecting developers, so I don't think astroquery/pyvo needs to chime in here.
(we don't even use EarthLocations in pyvo, and it's only used for the mpc module for astroquery, but even there it's a user input, so whatever they pass on will be used for the query)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubin isn't a telescope
5 participants