Update sites.json

[amillssma]

Added Sub-millimeter Array (SMA) on Mauna Kea, Hawaii to sites

Description

This pull request is to address ...

Fixes #

[hamogu]

Hi @amillssma!
Thanks for contributing to the list and making it more complete for everyone. I'm not a radio astronomer and I don't actually know how the "location of an array" is defined for arrays that consist of several different dishes.
All I can do it to check on google and see if there is actually a telescope at the location given: https://www.google.com/maps/@19.8248372,-155.4724211,537m/data=!3m1!1e3

It's definitely the right mountain, but I don't see a dish at that location in the middle of the screen. Again, that's probably OK, I just want to ask you to double-check one more time before I merge this that there are no typos in the coordinates! Can you just comment and let me know? Then I'm ready to merge this!

[dhomeier]

@hamogu there seems to be a typo in your lat/lon, or an inconsistency with Google coordinates – OpenStreetmap actually displays this centred right on the control building, with (some configurations of) the array actually visible to the NW.

[amillssma]

Hi, thanks for checking that! You're right, that GPS must be in the control building, I didn't bother to check. The reference antenna would be a better lat/long, and I've been informed the elevation of the control building should be close enough. I'll make those changes. Thanks again!

[amillssma]

Thank you!

…

On Tue, Oct 22, 2024 at 3:29 PM Hans Moritz Günther < ***@***.***> wrote: Merged #145 <#145> into gh-pages. — Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6IJW6ABE6WFTUWV3MZQHEDZ433ZPAVCNFSM6AAAAABQE6X4PGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUG44TKNZWG4YTCMI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Adam Mills he/him Hilo office: (808) 961-2952

[amillssma]

Hi, I tried pulling up the site in a test script with Observer.at_site and it says sma isn't there still. I tried adding the option refresh_cache=True, and it still couldn't find it. I really appreciate your help with my pull request, and any additional info on this issue would be greatly appreciated as well. Thanks, Adam On Tue, Oct 22, 2024 at 4:10 PM Mills, Adam ***@***.***> wrote:

…

Thank you! On Tue, Oct 22, 2024 at 3:29 PM Hans Moritz Günther < ***@***.***> wrote: > Merged #145 <#145> into > gh-pages. > > — > Reply to this email directly, view it on GitHub > <#145 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6IJW6ABE6WFTUWV3MZQHEDZ433ZPAVCNFSM6AAAAABQE6X4PGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUG44TKNZWG4YTCMI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- Adam Mills he/him Hilo office: (808) 961-2952

-- Adam Mills he/him Hilo office: (808) 961-2952

[pllim]

Hello, @amillssma , what package is Observer.at_site from? Should bring this issue to that package maintainer.

[amillssma]

It's astroplan, but the issue also occurs with EarthLocation.get_site_names(), which is from astropy.coordinates, so I believe the issue is with astropy. The Observer.at_site gets its site list from astropy.

…

On Thu, Oct 24, 2024, 5:38 AM P. L. Lim ***@***.***> wrote: Hello, @amillssma <https://github.com/amillssma> , what package is Observer.at_site from? Should bring this issue to that package maintainer. — Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6IJW6BE3M2WTJ336LXKVBLZ5EH7ZAVCNFSM6AAAAABQE6X4PGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGYZTEMJTG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[amillssma]

I see this message on the repository: The source for the astropy data repository (although the primary server is not on github) Could this be why it's not showing up yet? Does it have to be migrated to the primary server or something first? On Thu, Oct 24, 2024 at 12:23 PM Mills, Adam ***@***.***> wrote:

…

It's astroplan, but the issue also occurs with EarthLocation.get_site_names(), which is from astropy.coordinates, so I believe the issue is with astropy. The Observer.at_site gets its site list from astropy. On Thu, Oct 24, 2024, 5:38 AM P. L. Lim ***@***.***> wrote: > Hello, @amillssma <https://github.com/amillssma> , what package is > Observer.at_site from? Should bring this issue to that package > maintainer. > > — > Reply to this email directly, view it on GitHub > <#145 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6IJW6BE3M2WTJ336LXKVBLZ5EH7ZAVCNFSM6AAAAABQE6X4PGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGYZTEMJTG4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

-- Adam Mills he/him Hilo office: (808) 961-2952

[hamogu]

It works for me:

Python 3.13.0 | packaged by conda-forge | (main, Oct 17 2024, 12:32:35) [Clang 17.0.6 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.29.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from astropy.coordinates import EarthLocation

In [2]: ErtchLocation.of_site("SMA")
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Cell In[2], line 1
----> 1 ErtchLocation.of_site("SMA")

NameError: name 'ErtchLocation' is not defined

In [3]: EarthLocation.of_site("SMA")
Downloading http://data.astropy.org/coordinates/sites.json
|===================================================================================================================================================|  47k/ 47k (100.00%)         0s
Out[3]: <EarthLocation (-5464564.46944247, -2492931.81645504, 2150799.71399166) m>

Are you behind some kind of firewall or so that does not allow you to update the sites.json file from Python?

[dhomeier]

There seems to be an issue at least with the documentation. Can you try

EarthLocation.get_site_names(refresh_cache='http://data.astropy.org/coordinates/sites.json')

which will point it directly to the repository URL?

This is an alternative setting for force_download in _get_site_registry
https://github.com/astropy/astropy/blob/d7a6b978d1323e8bda860e50159819165b582a10/astropy/coordinates/earth.py#L574-L579
unfortunately not documented in the calling functions, but actually appears to be the only form that works, since True will be simply discarded here – did someone maybe miss that get_downloaded_sites itself is also using caching?
[Why does it seem Github is always taking 12 hour or more to update comments these days?]

[dhomeier]

It works for me:

Have you used EarthLocation before the update on that system (resp. after last clearing your cache)?
It looks like not, as it was downloading even without enforcing.
I could confirm that

>>> 'sma' in EarthLocation.get_site_names(refresh_cache=True)
False
>>> 'sma' in EarthLocation.get_site_names(refresh_cache='http://data.astropy.org/coordinates/sites.json')
Downloading http://data.astropy.org/coordinates/sites.json
|===========================================================================================================================|  47k/ 47k (100.00%)         0s
True
>>> EarthLocation.of_site('sma')
<EarthLocation (-5464564.46944247, -2492931.81645504, 2150799.71399166) m>
>>> 'sma' in EarthLocation.get_site_names(refresh_cache=True)
False
>>> EarthLocation.of_site('sma')
Traceback (most recent call last):
 <UnknownSiteException>

so passing the URL does enforce the download, but only for the present session without updating the (persistent) cache, and running with refresh_cache=True even wipes that copy.
I don't really know how the whole caching mechanisms (are supposed to) work, but also noted that directly calling
get_pkg_data_contents('coordinates/sites.json', cache=False) is triggering a download, but still not updating the cache – even afterwards, get_pkg_data_filename('coordinates/sites.json') on my system was pointing to a subdir in ~/astropy/cache with > 3 year old files!

So the only reliable way to get this to work seems to manually wipe the cache with

from astropy.utils.data import clear_download_cache
clear_download_cache(hashorurl='http://data.astropy.org/coordinates/sites.json')

but that can't really be the way this is supposed to work.

[amillssma]

Thank you for your work on this! Just to confirm I can now see it when I add the url to refresh_cache. This was my first pull request!

…

On Fri, Oct 25, 2024 at 3:22 AM Derek Homeier ***@***.***> wrote: It works for me: Have you used EarthLocation before the update on that system (resp. after last clearing your cache)? It looks like not, as it was downloading even without enforcing. I could confirm that >>> 'sma' in EarthLocation.get_site_names(refresh_cache=True)False>>> 'sma' in EarthLocation.get_site_names(refresh_cache='http://data.astropy.org/coordinates/sites.json')Downloading http://data.astropy.org/coordinates/sites.json |===========================================================================================================================| 47k/ 47k (100.00%) 0sTrue>>> EarthLocation.of_site('sma')<EarthLocation (-5464564.46944247, -2492931.81645504, 2150799.71399166) m>>>> 'sma' in EarthLocation.get_site_names(refresh_cache=True)False>>> EarthLocation.of_site('sma')Traceback (most recent call last): <UnknownSiteException> so passing the URL does enforce the download, but only for the present session without updating the (persistent) cache, and running with refresh_cache=True even wipes that copy. I don't really know how the whole caching mechanisms (are supposed to) work, but also noted that directly calling get_pkg_data_contents('coordinates/sites.json', cache=False) is triggering a download, but still not updating the cache – even afterwards, get_pkg_data_filename('coordinates/sites.json') on my system was pointing to a subdir in ~/astropy/cache with > 3 year old files! So the only reliable way to get this to work seems to manually wipe the cache with from astropy.utils.data import clear_download_cacheclear_download_cache(hashorurl='http://data.astropy.org/coordinates/sites.json') but that can't really be the way this is supposed to work. — Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6IJW6HF3CNHBIL26DTBJMDZ5JAZNAVCNFSM6AAAAABQE6X4PGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXG43DQMZWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Adam Mills he/him Hilo office: (808) 961-2952