Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fallback operator for async task #1538

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Feb 13, 2025

Since we decided to close: #1273 the fallback for async operator class does not makes sense

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit d45112e
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67aee3044bdfc50009e7c42f

Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2025

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: d45112e
Status: ✅  Deploy successful!
Preview URL: https://6a5570d5.astronomer-cosmos.pages.dev
Branch Preview URL: https://remove-async-fallback-class.astronomer-cosmos.pages.dev

View logs

@pankajastro pankajastro marked this pull request as ready for review February 13, 2025 18:11
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc area:testing Related to testing, like unit tests, integration tests, etc labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (53dfcb7) to head (d45112e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
+ Coverage   97.19%   97.33%   +0.14%     
==========================================
  Files          80       80              
  Lines        4845     4845              
==========================================
+ Hits         4709     4716       +7     
+ Misses        136      129       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cosmos/operators/_asynchronous/base.py Outdated Show resolved Hide resolved
@pankajkoti pankajkoti force-pushed the remove_async_fallback_class branch from b45d48d to d45112e Compare February 14, 2025 06:30
@pankajkoti pankajkoti merged commit f584aac into main Feb 14, 2025
66 checks passed
@pankajkoti pankajkoti deleted the remove_async_fallback_class branch February 14, 2025 06:33
@pankajastro pankajastro added this to the Cosmos 1.9.0 milestone Feb 14, 2025
@pankajkoti pankajkoti mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc area:testing Related to testing, like unit tests, integration tests, etc size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[async] Fallback to using dbt-core to run transformation if async fails
2 participants