-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add teardown task #1529
Add teardown task #1529
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Deploying astronomer-cosmos with
|
Latest commit: |
81ae672
|
Status: | ✅ Deploy successful! |
Preview URL: | https://87afda90.astronomer-cosmos.pages.dev |
Branch Preview URL: | https://teardown-task.astronomer-cosmos.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pankajastro some early feedback. Please, could you confirm that the teardown task is not emitting any datasets (outlets)
d04da59
to
ddc86a1
Compare
ddc86a1
to
2dfa697
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
+ Coverage 97.30% 97.32% +0.02%
==========================================
Files 80 80
Lines 4784 4821 +37
==========================================
+ Hits 4655 4692 +37
Misses 129 129 ☔ View full report in Codecov by Sentry. |
Yes, teardown task do not emit any datasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like we have a conflict with main that needs to be resolved.
This PR introduces a teardown node in the Cosmos DAG that deletes SQL files from the remote location that were uploaded by the setup task. This ensures proper cleanup of resources after the task execution.
Key Changes:
Teardown Node Addition:
A new teardown task is added to the Cosmos DAG that deletes the SQL files from the remote location. The files deleted are the ones uploaded by the setup task earlier in the DAG.
New Config: enable_teardown_async_task:
A configuration option
enable_teardown_async_task
, is introduced to enable or disable this feature. This config is enabled by default.Setting this config to False will skip the teardown step, while setting it to True will ensure the deletion task runs after the setup.
Applicable Only for AIRFLOW_ASYNC Execution Mode:
This feature is only triggered when the DAG is running in AIRFLOW_ASYNC execution mode
closes: #1232