Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

235 - Gas Estimation #236

Merged
merged 16 commits into from
Feb 22, 2024
Merged

235 - Gas Estimation #236

merged 16 commits into from
Feb 22, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 1, 2024

Solves #235

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/235-gas-estimation-staging branch from e85398a to 8dc83a3 Compare February 20, 2024 00:44
@0xmemorygrinder 0xmemorygrinder self-requested a review February 20, 2024 00:57
@0xmemorygrinder 0xmemorygrinder self-assigned this Feb 20, 2024
@0xmemorygrinder 0xmemorygrinder marked this pull request as ready for review February 20, 2024 00:57
Copy link
Contributor

@0xmemorygrinder 0xmemorygrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

You should also add comments in your code because it is a total black box and takes a lot of focus to understand the logic.

Copy link
Contributor

@0xmemorygrinder 0xmemorygrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK, performing functional review

@0xtekgrinder 0xtekgrinder merged commit 3cfa144 into dev Feb 22, 2024
24 checks passed
@0xmemorygrinder
Copy link
Contributor

LGTM

@0xmemorygrinder 0xmemorygrinder deleted the feature/235-gas-estimation-staging branch February 22, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants