Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

231 - osmium-slither preformence issue #232

Merged
merged 10 commits into from
Feb 22, 2024
Merged

231 - osmium-slither preformence issue #232

merged 10 commits into from
Feb 22, 2024

Conversation

github-actions[bot]
Copy link

Solves #231

@0xSwapFeeder 0xSwapFeeder force-pushed the bug/231-osmium-slither-preformence-issue-staging branch from 67b1d69 to 3992b5a Compare February 5, 2024 16:42
@0xSwapFeeder 0xSwapFeeder marked this pull request as ready for review February 5, 2024 16:47
@0xSwapFeeder
Copy link
Contributor

0xSwapFeeder commented Feb 5, 2024 •
edited by 0xmemorygrinder
Loading

@0xtekgrinder Please review my code

0xtekgrinder
0xtekgrinder suggested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, also don't forget to lint and format

remove-me-ba2314d8e5b1421b91ce.txt Outdated Show resolved Hide resolved
toolchains/solidity/core/crates/slither-server/Cargo.toml Outdated Show resolved Hide resolved
toolchains/solidity/core/crates/slither-server/src/error.rs Show resolved Hide resolved
toolchains/solidity/core/crates/slither-server/src/types.rs Outdated Show resolved Hide resolved
toolchains/solidity/core/crates/slither-server/src/utils.rs Outdated Show resolved Hide resolved
toolchains/solidity/core/crates/slither-server/src/slither.rs Outdated Show resolved Hide resolved
toolchains/solidity/core/crates/slither-server/src/main.rs Outdated Show resolved Hide resolved
@0xSwapFeeder
Copy link
Contributor

Well, I have ran a yarn install but it seems to not produce any changes, any clues for the CI ? @0xmemorygrinder @0xtekgrinder

0xmemorygrinder
0xmemorygrinder reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@0xmemorygrinder 0xmemorygrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change otherwise LGTM

toolchains/solidity/core/crates/slither-server/Cargo.toml Outdated Show resolved Hide resolved
@0xSwapFeeder 0xSwapFeeder force-pushed the bug/231-osmium-slither-preformence-issue-staging branch from 5828ac8 to a4c8a32 Compare February 22, 2024 01:01
@0xmemorygrinder 0xmemorygrinder force-pushed the bug/231-osmium-slither-preformence-issue-staging branch from edee6af to e84ce28 Compare February 22, 2024 06:07
@0xmemorygrinder 0xmemorygrinder requested review from 0xmemorygrinder and removed request for 0xtekgrinder February 22, 2024 06:26
@0xSwapFeeder 0xSwapFeeder merged commit 4df85ae into dev Feb 22, 2024
24 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the bug/231-osmium-slither-preformence-issue-staging branch February 22, 2024 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xtekgrinder 0xtekgrinder 0xtekgrinder requested changes

@0xSwapFeeder 0xSwapFeeder 0xSwapFeeder left review comments

@0xmemorygrinder 0xmemorygrinder 0xmemorygrinder approved these changes

Assignees

@0xmemorygrinder 0xmemorygrinder

Labels
None yet
Projects
Project Management
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xSwapFeeder @0xmemorygrinder @0xtekgrinder