This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
176 - Compiler warnings / errors #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
0xmemorygrinder
force-pushed
the
feature/176-compiler-warnings-errors-staging
branch
from
0def9ce to
d1383fa
Compare
0xmemorygrinder
force-pushed
the
feature/176-compiler-warnings-errors-staging
branch
2 times, most recently
from
d167613 to
2b035f3
Compare
0xmemorygrinder
force-pushed
the
dev
branch
5 times, most recently
from
f87bf0b to
7369634
Compare
0xmemorygrinder
force-pushed
the
feature/176-compiler-warnings-errors-staging
branch
from
2b035f3 to
4a9fb21
Compare
…handle foundry as external executable
0xmemorygrinder
force-pushed
the
feature/176-compiler-warnings-errors-staging
branch
from
4a9fb21 to
29d45bc
Compare
0xmemorygrinder
force-pushed
the
feature/176-compiler-warnings-errors-staging
branch
from
f1f25b0 to
e0eb6a0
Compare
0xSwapFeeder
reviewed
Dec 7, 2023
| use std::path::PathBuf; | ||
|
|
||
| pub fn find_forge_executable() -> Result<PathBuf, Error> { | ||
| which::which("forge").map_err(|_| Error::FoundryExecutableNotFound) |
There was a problem hiding this comment.
Should I do to same with slither and solc in the slither impl @0xmemorygrinder ?
0xSwapFeeder
force-pushed
the
feature/176-compiler-warnings-errors-staging
branch
from
c33c91b to
18772ce
Compare
0xmemorygrinder
deleted the
feature/176-compiler-warnings-errors-staging
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #176