Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error when connection can't be established:
I think it's related to a change in ruby 3.3:
https://rubyreferences.github.io/rubychanges/3.3.html#standard-library
https://bugs.ruby-lang.org/issues/19012
So here I propose to make sure we operate on a string, not nil.
In few places we could also just check for
#nil? or empty?
but#to_s
in happy path is basically a noop.Not much to add or change in tests.