chore(core, sequencer): rename connect oracle to price feed #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conductor
Fraser999
force-pushed
the
fraser/1881-rename-connect-oracle
branch
from
38e5684 to
cd12f12
Compare
…' into fraser/1881-rename-connect-oracle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The term "connect" in the context of the price feed oracle has been replaced with "price feed".
Note that this PR is based on top of #1917, so is effectively blocked by it.
Background
Using the product's name "connect" was confusing. There was a discussion around replacing this with "oracle", but given that we may provide other oracles in the future, it was decided to rename this to "price feed" and nest the instances in a new module "oracles".
Changes
Testing
No additional tests required.
Changelogs
No updates required - the changelogs will be updated once the feature is complete.
Breaking Changelist
The feature branch includes breaking changes already, this PR only changes a few of these - no further breakages.
Related Issues
Closes #1881.