Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protos): rename astria.bundle -> astria.auction and Bundle -> Bid #1889

Closed
wants to merge 1 commit into from

Conversation

itamarreif
Copy link
Contributor

Summary

Brief summary of the changes made, ie "what?"

Background

Brief background on why these changes were made, ie "why?"

Changes

  • Rename Bundle to Bid
  • Rename the astria.bundle package to astria.auction

Testing

How are these changes tested?

Changelogs

Ensure all relevant changelog files are updated as necessary. See
keepachangelog for change
categories. Replace this text with e.g. "Changelogs updated." or "No updates
required." to acknowledge changelogs have been considered.

Breaking Changelist

  • Changes the package name for the auction api
  • Changes the name of Bundle to Bid

Related Issues

closes #1888

@itamarreif itamarreif added proto pertaining to the Astria Protobuf spec auctioneer labels Jan 2, 2025
@itamarreif itamarreif self-assigned this Jan 2, 2025
@SuperFluffy SuperFluffy changed the title refactor(auctioneer, protos): rename bundle apis refactor(protos): rename astria.bundle -> astria.auction and Bundle -> Bid Jan 10, 2025
@SuperFluffy
Copy link
Member

Merged this into #1839, regenerated all code and fixed auctioneer to use it. This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auctioneer proto pertaining to the Astria Protobuf spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up names in Bundle API
2 participants