chore(composer): propagate errors

[ethanoroshiba]

Summary

Propagate errors which occur while composer is starting up and/or running so that the will be returned by the Composer's handle.

Background

Previously, composer would only exit with an error if the collectors' or executor's status channels were closed, and then the error message did not provide detailed information about the error that occurred. Additionally, if either of the wait_for_* loops failed, the composer would not shut down gracefully. This change is meant to expose the first eyre report which causes the composer to shut down, and gracefully shut down in all circumstances.

Changes

• Started collector and executor wait_for_ready loops concurrently, and continue with graceful shutdown even if these fail.
• Store the first error composer encounters, and return it after graceful shutdown. If waiting for collectors or executor fails, Composer continues so that it can ascertain the underlying error from the task which caused it.

Testing

Passing all tests

Changelogs

Changelog updated

Related Issues

closes #1833

[SuperFluffy]

Left a bunch of comments. This does not seem to be a chore but more of a refactor.

[SuperFluffy]

This Debug log might look funky because debug logs are usually multiple lines, so the first line will have a tab before it, but the subsequent lines will not. A nice crate to do that on every line is https://crates.io/crates/indenter.

But I think the error here is the single-line astria-eyre one? Then in this case my comment likely doesn't matter.

[ethanoroshiba]

Potentially, but if for some reason the error is incorrect it could have a longer source chain. I could just remove the indentation, but I'm not sure I dislike the indenting as it is tbh. It'd look similar to how one would write paragraphs normally:

did not find expected executor error message
expected cause:
      some expected cause
actual cause chain:
      {0: asdfasdlskjdflksdjlalskdjflsalsdkjflasjdfalkdsfj, 1: asflkajsldkfjalksjdflakjsdfkasdjflka
sjdflja, 2: askdjfaksjdfkjasdkfhaksjdfhjksadjfh, 3: some underlying error}