Skip to content

Commit

Permalink
fix(core): revert From ed25519_consensus types for crypto mod (#1220)
Browse files Browse the repository at this point in the history
## Summary
revert `From` ed25519_consensus types for crypto mod

## Background
We want to minimize the surface of our public astria-core API when it
comes to foreign (third party) types.
  • Loading branch information
noot authored Jun 27, 2024
1 parent 811c95d commit e0907e0
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions crates/astria-core/src/crypto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,6 @@ impl<'a> From<&'a SigningKey> for VerificationKey {
}
}

impl From<Ed25519SigningKey> for SigningKey {
fn from(key: Ed25519SigningKey) -> Self {
Self(key)
}
}

impl TryFrom<&[u8]> for SigningKey {
type Error = ed25519_consensus::Error;

Expand Down Expand Up @@ -216,14 +210,6 @@ impl AsRef<[u8]> for VerificationKey {
}
}

impl From<Ed25519VerificationKey> for VerificationKey {
fn from(key: Ed25519VerificationKey) -> Self {
Self {
key,
}
}
}

impl TryFrom<&[u8]> for VerificationKey {
type Error = Error;

Expand Down Expand Up @@ -276,12 +262,6 @@ impl From<[u8; 64]> for Signature {
}
}

impl From<Ed25519Signature> for Signature {
fn from(signature: Ed25519Signature) -> Self {
Self(signature)
}
}

impl TryFrom<&[u8]> for Signature {
type Error = Error;

Expand Down

0 comments on commit e0907e0

Please sign in to comment.