feat: Theoros v1.0 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhercha
requested review from
JordyRo1 and
EvolveArt
and removed request for
JordyRo1
EvolveArt
requested changes
Nov 3, 2024
|
|
||
| let update = match event.update { | ||
| DispatchUpdate::SpotMedian { update, feed_id: _ } => update, | ||
| pub async fn build_from(state: &AppState, chain_name: EvmChainName, feed_id: String) -> anyhow::Result<Calldata> { |
There was a problem hiding this comment.
we can use a builder pattern here
There was a problem hiding this comment.
We could but I'm not sure about the actual benefits since in practice we don't really "customize" how we call this function. But it would be prettier for sure
There was a problem hiding this comment.
easier to refactor in the future when there are more chain types and other stuff in the state
There was a problem hiding this comment.
also adds some default values which I think makes sense
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #77
Theoros
UnsignedCheckpoints"queue",Updated
Fixed
pragma:update_feedjs script,Removed
pragma-clirepositoryindexer-starting-block: It is useless to index from a block greater thancurrent_block - 5- we don't store any persistent data on Theoros and we're only interested in the latest updates. We can even docurrent_block - 2or 3.To-do in a follow-up PR:
Logs example: