Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandartHookMetadata construction fix #130

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

EgeCaner
Copy link
Contributor

@EgeCaner EgeCaner commented Feb 12, 2025

StandartHookMetadata contstruction fix.

  • Variant const to u8 to u16.
  • Variant added to metadata with append_u16 instead of casting to u128 which results in error due trying to read it via read_u16 in StandartHookMetadata::variant.
  • u256 variables appended via append_u256
  • Zero address check for required_hook in mailbox ctor
  • Zero address check for setters for required hook & default hook & default ism in mailbox
  • Zero address handling for custom hook in mailbox-dispatch alongside Option::None

@JordyRo1 JordyRo1 merged commit 28a2c62 into astraly-labs:main Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants