-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Git LFS support to uv-git
crate
#10335
Merged
+59
−1
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cfaa896
Updated `uv-git` to support Git LFS.
sydduckworth 675059d
Updated logic for locating Git LFS to be more portable.
sydduckworth cc7b8e1
Merge branch 'astral-sh:main' into git-lfs-support
sydduckworth 6e1e903
Update to preserve semver compatibility.
sydduckworth baa129c
Merge branch 'astral-sh:main' into git-lfs-support
sydduckworth ccadb17
Updated environment variable documentation
sydduckworth 893d28d
Merge branch 'astral-sh:main' into git-lfs-support
sydduckworth 9577686
Review
zanieb 3b3c277
Merge branch 'astral-sh:main' into git-lfs-support
sydduckworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain this detection method is portable to all end user systems. For example, I can have git lfs installed and working but I not have git-lfs binary on the path. I think probing
git lfs
directly is likely the most portable approach.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've updated the logic so now instead of searching for
git-lfs
on the path, it just tries to rungit lfs version
the first time LFS is invoked and uses the success of that command as an indicator of LFS availability.I'd definitely be interested in if anyone has a cleaner way of determining whether LFS is available. I was initially going to just check if the LFS fetch command returned
127
(command not found), but that return code isn't available in Powershell, so that approach isn't portable across shells.