Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npx vsce package should work #120

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

SoonIter
Copy link
Member

  1. @types/vscode has to match engines: vscode
    68663fe008b27028e96165a390a60ddf

  2. using pnpm as pkg manager should have no dependencies and bundle everything, because vsce package use npm list rather than pnpm list

image
  1. add .vscodeignore to reduce pkg installation size

Review steps

  1. npx @vscode/vsce@latest package

  2. install the extension from .vsix and check the features

Copy link

ellipsis-dev bot commented Feb 12, 2024

Skipped PR review on 90bf532 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.


Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.

Generated with ❤️ by ellipsis.dev

@HerringtonDarkholme HerringtonDarkholme merged commit c607b14 into ast-grep:main Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants