-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
46 auth flow #48
Closed
Closed
46 auth flow #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this new variable will be necessary so that redirects happen properly when the client is using their own domain, but pointing it to the softserv.cloud instance. - ref: #46
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
when this branch was deployed to staging, I received and internal server error while trying to sign in. after allowing access, I was redirected back to https://phenovista-staging.softserv.cloud/api/auth/error. I found the initial code for `redirect` at https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/lib/init.ts#L38-L42. I'm adding it in hopes to bypass the server error so I can continue testing on staging.
logged values from staging: ``` bash { url: 'https://store.phenovista.com/browse', baseUrl: 'https://phenovista.softserv.cloud', clientUrl: 'https://store.phenovista.com', url_Origin: 'https://store.phenovista.com', baseUrl_Origin: 'https://phenovista.softserv.cloud' } ```
new error: "https://next-auth.js.org/errors#oauth_callback_error PKCE code_verifier cookie was missing. { error: TypeError: PKCE code_verifier cookie was missing." - ref: nextauthjs/next-auth#7491 (comment)
- I added a new domain to vercel to point at this branch preview url. I'm adding test language to the browse page to confirm it works.
not sure if this will work properly on vercel actually... ref: https://assaydepot.slack.com/archives/C0313NK4SMS/p1707258081079489?thread_ts=1707153816.402189&cid=C0313NK4SMS
going to deploy this code to staging and see if I can force it to redirect to vercel on redirect after signing in.
when starting at https://phenovista-staging.softserv.cloud/, I pressed "sign in" and was taken to the sign in page. clicking "allow" redirected me to https://phenovista-test.vercel.app/ as expected. however, I was not signed in. going back to phenovista-staging showed I was signed in there though. 🤔
update the production `appBaseUrl` and `nextAuthUrl` variables to point at pheno's domain instead of softservs. attempting to fix the redirect still.
closing in favor of #55. I wanted to keep the code for knowledge's sake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs #issuenumber
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Testing
OAUTH_CALLBACK_ERROR
from below)Notes
initial `OAUTH_CALLBACK_ERROR`
second `OAUTH_CALLBACK_ERROR`