kaspad: append archival argument, disabled by default. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Perchanov <[email protected]>
aspect
reviewed
Jul 29, 2024
| @@ -12,6 +12,7 @@ pub struct Config { | |||
| network: Network, | |||
| data_folder: Option<PathBuf>, | |||
| enable_upnp: bool, | |||
| archival: bool, | |||
There was a problem hiding this comment.
This field needs to be tagged with #[serde(default)], otherwise the previous version of the config file will fail to load (as the field is missing), resetting the entire config (as currently, it will fall back to a general error handling).
The default value for bool is false. You changed the new() ctor, which is what is used to create a new config, however, when config is deserialized, it uses serde.
There was a problem hiding this comment.
done, i see that without default, old configuration treated as invalid and khost starts as new deployment.
Signed-off-by: Dmitry Perchanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~/.khost/config.jsonentry:default:
"archival": false,enable archival argument:
"archival": true,Set data-dir, for example:
"data_folder": "/srv/kaspad/",