Skip to content

Commit

Permalink
chore: update to rules_js 1.17.0 and aspect_bazel_lib 1.24.2 (#303)
Browse files Browse the repository at this point in the history
  • Loading branch information
gregmagolan authored Feb 2, 2023
1 parent 3fee9c2 commit 866b9a1
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 12 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ jobs:
# Don't test RBE with on MacOS (not configured)
- os: macos-latest
config: rbe
# Don't test MacOS with Bazel 5.3.2 (toolchain issues)
- os: macos-latest
bazelversion: 5.3.2
# Don't test bzlmod with Bazel 5 (not supported)
- bazelversion: 5.3.2
folder: e2e/bzlmod
Expand Down
4 changes: 2 additions & 2 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ module(

bazel_dep(name = "bazel_skylib", version = "1.3.0")
bazel_dep(name = "rules_nodejs", version = "5.5.3", dev_dependency = True)
bazel_dep(name = "aspect_rules_js", version = "1.15.1")
bazel_dep(name = "aspect_bazel_lib", version = "1.23.3")
bazel_dep(name = "aspect_rules_js", version = "1.17.0")
bazel_dep(name = "aspect_bazel_lib", version = "1.24.2")
2 changes: 1 addition & 1 deletion e2e/bzlmod/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module(
)

# repeated here only because we use the platforms definitions for rbe
bazel_dep(name = "aspect_rules_js", dev_dependency = True, version = "1.15.1")
bazel_dep(name = "aspect_rules_js", dev_dependency = True, version = "1.17.0")
bazel_dep(name = "aspect_rules_ts", dev_dependency = True, version = "0.0.0")
bazel_dep(name = "bazel_skylib", dev_dependency = True, version = "1.3.0")

Expand Down
6 changes: 3 additions & 3 deletions internal_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def rules_ts_internal_deps():

http_archive(
name = "aspect_rules_jasmine",
sha256 = "0357d45b5dba77004931db83ced43c6c432eee658a51d1876a9f2b57838e4080",
strip_prefix = "rules_jasmine-0.2.1",
url = "https://github.com/aspect-build/rules_jasmine/archive/refs/tags/v0.2.1.tar.gz",
sha256 = "089250b6afda54099d7a3bc4e0f0765451356f329d105a32d1a78703edf70320",
strip_prefix = "rules_jasmine-0.3.0",
url = "https://github.com/aspect-build/rules_jasmine/archive/refs/tags/v0.3.0.tar.gz",
)
12 changes: 6 additions & 6 deletions ts/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@ def rules_ts_dependencies(ts_version_from = None, ts_version = None, ts_integrit

http_archive(
name = "aspect_rules_js",
sha256 = "928ba25fa82cfe7983f89118677413dc74dbc5d0360fa969da07ff22a9306052",
strip_prefix = "rules_js-1.15.1",
url = "https://github.com/aspect-build/rules_js/archive/refs/tags/v1.15.1.tar.gz",
sha256 = "2868c450aaa83ec19ee172015c6445264b6422d6d0d61da6af47ec8a159b0e5a",
strip_prefix = "rules_js-1.17.0",
url = "https://github.com/aspect-build/rules_js/archive/refs/tags/v1.17.0.tar.gz",
)

http_archive(
name = "aspect_bazel_lib",
sha256 = "79623d656aa23ad3fd4692ab99786c613cd36e49f5566469ed97bc9b4c655f03",
strip_prefix = "bazel-lib-1.23.3",
url = "https://github.com/aspect-build/bazel-lib/archive/refs/tags/v1.23.3.tar.gz",
sha256 = "ef83252dea2ed8254c27e65124b756fc9476be2b73a7799b7a2a0935937fc573",
strip_prefix = "bazel-lib-1.24.2",
url = "https://github.com/aspect-build/bazel-lib/archive/refs/tags/v1.24.2.tar.gz",
)

npm_dependencies(ts_version_from = ts_version_from, ts_version = ts_version, ts_integrity = ts_integrity)

0 comments on commit 866b9a1

Please sign in to comment.