Remove openssl #269
Merged
Remove openssl #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! There was a recent PR that should remove the requirement to build the binaries from source, and not push the rust dependencies onto the consumer too. We should still land this as this is the right shape. Are you able to sign the CLA? |
btobolaski
force-pushed
the
remove-openssl
branch
from
21b7574 to
b7be813
Compare
|
I needed to run it through my Company but, it is now signed. |
alexeagle
reviewed
Feb 21, 2024
Users shouldn't have a rust dependency. Some work is needed to publish binaries on releases.
alexeagle
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Test plan
#233 was mentioned as a fix for #218 but #233 includes a dependency on openssl. This dependency on openssl makes building containers on MacOS difficult as we then need to cross build openssl. I see that there was an attempt to remove the openssl dependency
rattler_installs_packageshowever,native-tlsis in the default features and is the only default feature. Disablingdefault-featuresremoves the dependency on openssl.