Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spotbugs warnings for missing classes #494

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vinnybod
Copy link
Contributor

@vinnybod vinnybod commented Mar 7, 2025

We noticed some non-fatal warnings when running spotbugs about missing classes.
This uses -auxclasspath to add the compile time jars to remove those warnings.

Example:

The following classes needed for analysis were missing:
  org.apache.kafka.common.Uuid

We also noticed this same issue happens in rules_jvm's spotbugs rule as well.

Note: This fixes the errors for java_library but not java_binary because the JavaInfo provider lacks compile time jar information for binaries.

Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Covered by existing test cases
  • New test cases added

nlou9 and others added 6 commits March 7, 2025 14:09
We noticed some non-fatal warnings when running spotbugs about missing classes.
This uses -auxclasspath to add the compile time jars to remove those warnings.

Example:
```
The following classes needed for analysis were missing:
  org.apache.kafka.common.Uuid
```

We also noticed this same issue happens in rules_jvm's spotbugs rule as well.

Note: This fixes the errors for java_library but not java_binary because the JavaInfo provider lacks compile time jar information for binaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants