Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gherkin Support #491

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Add Gherkin Support #491

merged 4 commits into from
Mar 5, 2025

Conversation

ericmcbride
Copy link
Contributor

Added Gherkin (Feature File) support. We currently use prettier-plugin-gherkin for linting our feature files, and we use the aspect_rules_lint for everything else. Wanted to add this feature so we don't have to maintain a one off.

Changes are visible to end-users: yes/no

Adds a new feature for users to use prettier-plugin-gherkin w prettier to add functionality to formatting feature files.

Test plan

  • Covered by existing test cases
  • Added an example

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2025

CLA assistant check
All committers have signed the CLA.

@ericmcbride
Copy link
Contributor Author

@alexeagle

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ericmcbride
Copy link
Contributor Author

@alexeagle I made the changes. Im running the 2 tests that failed locally and im running the suggestions but they are not working. I didnt touch the files so im confused whats going on there

@alexeagle
Copy link
Member

@ericmcbride yeah the suggested fix command is incorrect, as pointed out in #482

I'll get this green and landed :)

@alexeagle alexeagle merged commit 09edc0b into aspect-build:main Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants