Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test coverage for format binary #126

Merged
merged 2 commits into from
Jan 29, 2024
Merged

ci: add test coverage for format binary #126

merged 2 commits into from
Jan 29, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Jan 27, 2024

I suggested this in 18ca190

Note, there ought to be more testing that would have caught this. I spent some time writing a bats test here

Should be able to catch most regressions this way.

Fixes #121


Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • New test cases added

This is a beginning, if the pattern works I'll apply it to remaining languages.
Should be able to catch most regressions this way.
@alexeagle alexeagle requested a review from thesayyn January 28, 2024 00:06
@alexeagle alexeagle marked this pull request as ready for review January 28, 2024 00:06
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌯

@alexeagle alexeagle merged commit 15fcab9 into main Jan 29, 2024
8 checks passed
@alexeagle alexeagle deleted the formatter_testing branch January 29, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JSON format does not seem to be supported
3 participants