Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: overhaul of format.sh #105

Merged
merged 2 commits into from
Jan 19, 2024
Merged

refactor: overhaul of format.sh #105

merged 2 commits into from
Jan 19, 2024

Conversation

alexeagle
Copy link
Member

Use GitHub Linguist to define the file extensions for each language, getting much more accurate. Extract a helper function for listing files we want to format to reduce duplication.


Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Manual testing; please provide instructions so we can reproduce:
    Ran format.sh after changing code in each language

@alexeagle alexeagle requested review from jbedard and mattem January 18, 2024 23:57
Use GitHub Linguist to define the file extensions for each language, getting much more accurate.
Extract a helper function for listing files we want to format to reduce duplication.
@alexeagle alexeagle force-pushed the refactor_formatter_bin branch from 803a3f3 to a41f311 Compare January 19, 2024 00:00
@alexeagle alexeagle requested a review from thesayyn January 19, 2024 17:10
@alexeagle alexeagle merged commit 175da17 into main Jan 19, 2024
7 checks passed
@alexeagle alexeagle deleted the refactor_formatter_bin branch January 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants