refactor: hoist oci_python_image example to root module #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hm, I can't tell if there's just a missing docker daemon on the Aspect Workflows runner? But I didn't get this passing locally on podman either. |
|
Hmm, looks like testcontainers is failing to spin up the ryuk container, needs some digging, i'd be okay with disabling the test for now. |
alexeagle
force-pushed
the
py_coverage
branch
3 times, most recently
from
e8a1b44 to
2d8236b
Compare
alexeagle
force-pushed
the
py_coverage
branch
from
2d8236b to
2bf44ee
Compare
thesayyn
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the example less self-contained, but I added comments showing where this folder is linked to the root.
Changes are visible to end-users: no
Test plan