Models and IDs for rows

[aramk]

Added ID of the underlying model to table rows as a data- attribute. Added the model from the collection to the DOM element using $.data. Together these allow binding events to rows responding clicks. I've got selection of rows working in a separate project using this library and can add that in later on.

[aslagle]

This is pretty similar to #74. I don't think you need to add the model to the row, since when you use meteor's template.events to bind an event to the row, this will already be set to the model. Is there something you can't do with that?

[aramk]

If we need to add click events to the rows which run custom logic (e.g. Changing the route to another template based on the ID of the underlying model) is there a way to implement it without storing anything on the dom?

This PR mainly adds the option to extend the table outside of the library using just the row IDs, but another option could be to pass custom helpers which are executed on the rows?

On 14 Jul 2014, at 3:27 am, Amy Slagle [email protected] wrote:

This is pretty similar to #74. I don't think you need to add the model to the row, since when you use meteor's template.events to bind an event to the row, this will already be set to the model. Is there something you can't do with that?

—
Reply to this email directly or view it on GitHub.

[aslagle]

You can already use the model id (or other attributes) from a click event - like this:

Template.myTemplate.events({
    "click .reactive-table tr" : function (event) {
        Router.go("route", {_id: this._id});
    }
});

[aramk]

Ah that makes sense. I'll switch over my use cases, but I think you're right and this PR isn't necessary.