Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom row template support #176

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

custom row template support #176

wants to merge 5 commits into from

Conversation

Zibx
Copy link

@Zibx Zibx commented Mar 4, 2015

It's a standard case when we want to click on a table row and expand it to detailed view.

@Zibx
Copy link
Author

Zibx commented Mar 4, 2015

Adds isCustomRow and customRowTpl to config. First is a function that returns boolean value. second one is the template that we want to use.

@aslagle
Copy link
Owner

aslagle commented Mar 5, 2015

I'm going to come back to this after I release version 0.7.0. I like the idea but I think it would also be good to break out a reactiveTableRowTemplate from the rest of the html, that the row template option would override. It would be useful as an example of how to write a row template and maybe it could be used with something like aldeed:template-extension.

@Zibx
Copy link
Author

Zibx commented Mar 6, 2015

I'm new to meteor and originally I tried to make single property which can
return false if we do not need template and template if need, but there
were some too strange bugs. Also I would be glad if you tell me how to
debug meteor modules. I use publish>remove>add strategy and it's quite
boring and takes lots of time.

2015-03-05 16:51 GMT+03:00 Amy Slagle [email protected]:

I'm going to come back to this after I release version 0.7.0. I like the
idea but I think it would also be good to break out a
reactiveTableRowTemplate from the rest of the html, that the row template
option would override. It would be useful as an example of how to write a
row template and maybe it could be used with something like
aldeed:template-extension.


Reply to this email directly or view it on GitHub
#176 (comment)
.

@aslagle
Copy link
Owner

aslagle commented Mar 6, 2015

You can create a packages directory in your app and clone the repos for your packages in it, or symlink to them. Then you can run meteor add and it will use the local package instead of the published version, and automatically update the app when you change the package code. Much easier than publishing every change :)

@peterchoo
Copy link
Contributor

+1 for official support of expandable rows. We're currently trying to figure out how to do this cleanly, having issues with cleaning up on data changes.

@oscarcalvo oscarcalvo mentioned this pull request Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants