feat: remove filename restrictions

[jkroepke]

Fixes: #119

[jkroepke]

I'm using my branch in my CI. It works fine.

[aslafy-z]

Looks good! Can you add at least one test case?

[jkroepke]

Can you add at least one test case?

Done.

Take a look at:

https://github.com/bats-core/bats-assert
https://github.com/bats-core/bats-file

It should improve the readability of the test files.

Take a look here: https://github.com/jkroepke/helm-secrets/blob/master/tests/unit/clean.bats

[jBouyoud]

@aslafy-z Does it ready to merge and release ?

[jkroepke]

@jBouyoud you could take a look why tests are failed.

[jBouyoud]

@jkroepke --repo flag is not supported on helm 2.

Maybe you can move your test to 03-cli.bats and use something like :

@test "fetch tests/fixtures/example-chart/values.yaml" {
    run helm_init "$HELM_HOME"
    url="git+https://github.com/aslafy-z/helm-git@tests/fixtures/example-chart/values.yaml?ref=master"
    $HELM_GIT_DIRNAME/helm-git "" "" "" "$url" 2>/dev/null > "$HELM_GIT_OUTPUT/values.yaml"
    [ $? = 0 ]
    run stat "$HELM_GIT_OUTPUT/values.yaml"
    [ $status = 0 ]
}

[jkroepke]

flag is not supported on helm 2.

The whole feature does not exist in Helm 2.

[jBouyoud]

@jkroepke I don't understand your comment about Helm 2.
Based on https://github.com/aslafy-z/helm-git/blob/master/helm-git-plugin.sh#L96, this plugin seems design for Helm 2 and hopefully works on Helm3.

This commit jBouyoud@345cc81 add a test for this feature and remove the non compatible one. You can cherry pick it, I cannot push to your branch.

[aslafy-z]

Thanks @jkroepke @jBouyoud for your work. You're right, this plugin was designed at the time of Helm 2 and some awesome contributors worked on it to add support for Helm 3. I want to make it Helm 3 first in the future, will see when I get time to work on it.

@jkroepke can you merge in @jBouyoud change so we can push this forward? If you have time, adding a quick example to the readme would be perfect!

@jkroepke thanks for the tests sample, I opened #127 to track this enhancement. helm-secrets looks good!

[jkroepke]

@jkroepke I don't understand your comment about Helm 2.

I thought, the download plugins are helm 3 exclusive feature. But this is wrong.

[jkroepke]

@jkroepke can you merge in @jBouyoud change so we can push this forward?

Done.

[jkroepke]

Test are green, but tests are not executed.

See: #128

[aslafy-z]

Released as v0.10.0. Big thanks!