Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines recommend mandatory event functions excluded from trailing #1208

Merged
merged 1 commit into from
Oct 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -76,10 +76,10 @@ internal fun LauncherScreen(
items(state.entries) { entry ->
LauncherItem(
item = entry,
modifier = Modifier.padding(24.dp),
onClick = OnClick("launcher_goto", mapOf("screen" to entry.screen)) {
eventSink(NavEvent.GoTo(entry.screen))
},
modifier = Modifier.padding(24.dp),
)
}
}
@@ -116,8 +116,8 @@ private fun LauncherTopAppBar(modifier: Modifier = Modifier) {
@ExperimentalMaterial3Api
private fun LauncherItem(
item: LauncherScreen.State.Item,
modifier: Modifier = Modifier,
onClick: () -> Unit,
modifier: Modifier = Modifier,
) {
Card(
modifier = modifier.clickable(
Original file line number Diff line number Diff line change
@@ -77,17 +77,20 @@ internal fun BoxSetListScreen(
private fun BoxSetListScreen(
boxSetList: ImmutableList<BoxSet>,
contentPadding: PaddingValues,
onClick: (BoxSet) -> Unit,
modifier: Modifier = Modifier,
columnCount: Int = DEFAULT_COLUMN_COUNT,
onClick: (BoxSet) -> Unit,
) {
LazyVerticalGrid(
columns = GridCells.Fixed(columnCount),
modifier = modifier.padding(4.dp),
contentPadding = contentPadding,
) {
items(boxSetList) {
BoxSetCard(it) { onClick(it) }
items(boxSetList) { boxSet ->
BoxSetCard(
boxSet = boxSet,
onClick = { onClick(boxSet) },
)
}
}
}
@@ -96,8 +99,8 @@ private fun BoxSetListScreen(
@ExperimentalMaterial3Api
private fun BoxSetCard(
boxSet: BoxSet,
modifier: Modifier = Modifier,
onClick: () -> Unit,
modifier: Modifier = Modifier,
) {
Box(
modifier = modifier
Original file line number Diff line number Diff line change
@@ -133,9 +133,9 @@ private fun BackIconButton(onClick: () -> Unit) {
private fun DetailsScreen(
cards: ImmutableList<Card>,
contentPadding: PaddingValues,
onClick: (Card) -> Unit,
modifier: Modifier = Modifier,
columnCount: Int = DEFAULT_COLUMN_COUNT,
onClick: (Card) -> Unit,
) {
LazyVerticalGrid(
columns = GridCells.Fixed(columnCount),
Original file line number Diff line number Diff line change
@@ -22,8 +22,8 @@ private const val CAMERA_ANIMATE_DURATION = 2_000
@Composable
internal actual fun RouteMap(
state: RouteMapState,
modifier: Modifier,
onEndPosition: (LatLng) -> Unit,
modifier: Modifier,
) {
val cameraPositionState = rememberCameraPositionState()

Original file line number Diff line number Diff line change
@@ -13,6 +13,10 @@ public fun Circuit.Builder.addRoutePresenter(context: PlatformContext): Circuit.

public fun Circuit.Builder.addRouteUi(): Circuit.Builder {
return addUi<RouteScreen, RouteScreen.State> { state, modifier ->
RouteScreen(state, modifier) { state.eventSink(RouteScreen.Event.OnEndPosition(it)) }
RouteScreen(
state = state,
onEndPosition = { state.eventSink(RouteScreen.Event.OnEndPosition(it)) },
modifier = modifier,
)
}
}
Original file line number Diff line number Diff line change
@@ -19,8 +19,8 @@ internal data class RouteMapState(
@Composable
internal expect fun RouteMap(
state: RouteMapState,
modifier: Modifier = Modifier,
onEndPosition: (LatLng) -> Unit,
modifier: Modifier = Modifier,
)

internal data class LatLng(
Original file line number Diff line number Diff line change
@@ -25,12 +25,12 @@ internal object RouteScreen : Screen {
@Composable
internal fun RouteScreen(
state: RouteScreen.State,
modifier: Modifier = Modifier,
onEndPosition: (LatLng) -> Unit,
modifier: Modifier = Modifier,
) {
RouteMap(
state = state.mapState,
modifier = modifier,
onEndPosition = onEndPosition,
modifier = modifier,
)
}
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ import androidx.compose.ui.Modifier
@Composable
internal actual fun RouteMap(
state: RouteMapState,
modifier: Modifier,
onEndPosition: (LatLng) -> Unit,
modifier: Modifier,
) {
Text("Unsupported Platform")
}