Skip to content

Commit

Permalink
Trigger job finalization reliably from livehandler
Browse files Browse the repository at this point in the history
The livehandler cancels jobs them so it needs to load the Gru
plugin in order to enqueue the Minion job for finalizing job
results (and triggering the hook script).

Note that this problem was only revealed after removing the
`eval` in the function to enqueue the Minion jobs. Before,
this problem was simply ignored.

Note that the scheduler is already covered similarly.
  • Loading branch information
Martchus committed Mar 7, 2023
1 parent ace7332 commit 7a468c1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/OpenQA/LiveHandler.pm
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ sub startup ($self) {
push @{$self->plugins->namespaces}, 'OpenQA::LiveHandler::Plugin', 'OpenQA::Shared::Plugin';
$self->plugin('SharedHelpers');
$self->plugin('CSRF');
$self->plugin('Gru'); # to invoke $job->cancel() when stopping developer session

OpenQA::Setup::set_secure_flag_on_cookies_of_https_connection($self);

Expand Down

0 comments on commit 7a468c1

Please sign in to comment.