-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scheduled workflow #1391
Add a scheduled workflow #1391
Conversation
@ConorMacBride, based on our conversation in OpenAstronomy/github-actions-workflows#108, what is does |
Note I added the |
5ba8026
to
b5e2b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, should fail-fast
be true though?
It might as well be since this workflow just executes other workflows, meaning those workflows will show up as their own runs under |
This was successfully triggered manually: https://github.com/asdf-format/asdf/actions/runs/4225027648/jobs/7336904936 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the schedule workflow looks great. Glad you got it working.
I have noticed a few things have being occurring since we began splitting off the 2.15.x development for ASDF:
downstream
ands390x
workflows seem to be getting run on every push to themaster
and2.15.x
branches. Essentially this results in a lot of duplicated CI runs. In turn we seem to be running out of runners for our actual PRs, so we end up waiting for CI to run. Since bothdownstream
ands390x
both take a long time to complete (for some of their jobs) and are intended as "smoke" testing, they do not need to be run on every merge tomaster
or2.15.x
. In reality, they only need to be run on a schedule, when called for by the appropriate label in on a PR, or when we push a tag for a release.2.15.x
branch. The waycron
(scheduled) jobs work in GitHub actions is that they are only triggered on the default branch of the repo. Meaning our currentcron
jobs only run onmaster
at the current time. This means2.15.x
will only have tests run on it when changes are made to the branch, which will become an issue once the release is finalized.This PR intends to fix both of these problems by introducing a
scheduled
workflow, which at heart is a workflow which triggers the:ci
,downstream
, ands390x
workflows on bothmaster
and2.15.x
branches(later release branches can be added). This means thecron
only needs to be in thescheduled
workflow and not in any of our other workflows. Also, since we can ensure thedownstream
ands390x
workflows are properly triggered byscheduled
workflow, we can reduce the running ofdownstream
ands390x
on all merges to themaster
and2.15.x
branches, instead limiting them to the schedule, when called for within a PR, and on new tags.Note that these changes were based on the discussion in OpenAstronomy/github-actions-workflows#108, with the
scheduled
workflow largely based on https://github.com/sunpy/sunpy/blob/main/.github/workflows/scheduled_builds.yml.WORKFLOW_TOKEN
when this PR is merged.