Skip to content

Commit

Permalink
Support JDK11 as of IntelliJ 2019.1 EAP (#238)
Browse files Browse the repository at this point in the history
  • Loading branch information
ahus1 committed Mar 1, 2019
1 parent 19cc509 commit 6091f14
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
4 changes: 4 additions & 0 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ See https://github.com/asciidoctor/asciidoctor-intellij-plugin/wiki/Support-proj
== Release notes

=== 0.24.2 (preview, available from Github releases)

- Support JDK11 as of IntelliJ 2019.1 EAP (#238)

=== 0.24.1

- Upgrade to AsciidoctorJ 1.6.2 and JRuby 9.2.6.0 (it's still backed by Asciidoctor 1.5.8)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,14 @@ public void addNotify() {
// If scene is null then it will be set later and super.setEmbeddedScene(..) will init its scale properly,
// otherwise explicitly set scene scale to match JFXPanel.scaleFactor.
if (scene != null) {
TKScene tks = scene.impl_getPeer();
if (tks instanceof EmbeddedSceneInterface) {
((EmbeddedSceneInterface)tks).setPixelScaleFactor(scale);
try {
// this will no longer work with JDK 11
TKScene tks = scene.impl_getPeer();
if (tks instanceof EmbeddedSceneInterface) {
((EmbeddedSceneInterface)tks).setPixelScaleFactor(scale);
}
} catch (NoSuchMethodError e) {
// ignore
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/main/resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<idea-plugin version="2" url="https://github.com/asciidoctor/asciidoctor-intellij-plugin">
<id>org.asciidoctor.intellij.asciidoc</id>
<name>AsciiDoc</name>
<version>0.24.1</version>
<version>0.24.2</version>
<vendor email="[email protected]" url="http://asciidoctor.org">Asciidoctor Project</vendor>

<description><![CDATA[
Expand Down Expand Up @@ -29,6 +29,7 @@ Therefore, JetBrains OpenJDK pre-bundled with your IDE is recommended.

<change-notes><![CDATA[
<ul>
<li>0.24.2 Support JDK11 as of IntelliJ 2019.1 EAP (#238)
<li>0.24.1 Upgrade to AsciidoctorJ 1.6.2 and JRuby 9.2.6.0 (it's still backed by Asciidoctor 1.5.8)
<br>Upgrade to asciidoctor diagram 1.5.12
<br>Additional logging to analyze errors (#236)
Expand Down Expand Up @@ -62,7 +63,7 @@ Therefore, JetBrains OpenJDK pre-bundled with your IDE is recommended.

<!-- please see http://confluence.jetbrains.net/display/IDEADEV/Plugin+Compatibility+with+IntelliJ+Platform+Products
on how to target different products -->
<idea-version since-build="171.000"/> <!-- 2017.1 -->
<idea-version since-build="172.2465.6"/> <!-- 2017.2 -->
<!-- please see http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html -->
<depends>com.intellij.modules.lang</depends>

Expand Down

0 comments on commit 6091f14

Please sign in to comment.