Fix to ProGuard settings for hardcoded method name in NativeAudioEngi…

…ne.cpp
aschober · May 24, 2020 · 4625376 · 4625376
1 parent cf47623
commit 4625376
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro
@@ -15,3 +15,8 @@
 #-keepclassmembers class fqcn.of.javascript.interface.for.webview {
 #   public *;
 #}
+
+# Note: the onAudioData method name is hardcoded in NativeAudioEngine.cpp so need to tell ProGuard to skip it
+-keep public interface tech.schober.vinylcast.audio.NativeAudioEngineListener {
+     void onAudioData(byte[]);
+}
diff --git a/app/src/main/cpp/NativeAudioEngine.cpp b/app/src/main/cpp/NativeAudioEngine.cpp
@@ -81,6 +81,7 @@ void NativeAudioEngine::setAudioDataListener(JNIEnv *env, jobject instance, jobj
     jclass jClassAudioDataListener = env->GetObjectClass(callbackObject);
 
     //declare java method id
+    //Note: this method name is hardcoded so need to tell ProGuard to skip it
     jmethodID jMethodIdOnAudioData = env->GetMethodID(jClassAudioDataListener, "onAudioData", "([B)V");
 
     //check null