Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a coordinate channel input #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pattonw
Copy link
Contributor

@pattonw pattonw commented Feb 21, 2019

I haven't done any tests to determine whether the coordinate channel is useful, but if you want it here is an implementation.

Copy link
Owner

@aschampion aschampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this could be another breaking dependency for, e.g., Keras upgrades and we don't yet have evidence of practical benefit, I'm going to leave this unmerged but open for now.

diluvian/coord.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants