Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve robustness in parsing numerical values. #95

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Improve robustness in parsing numerical values. #95

merged 1 commit into from
Sep 13, 2024

Conversation

hoangtungdinh
Copy link
Contributor

Description

This PR ensures that the checker bundle doesn't fail when it cannot parse numerical values.

Main changes

  1. Introduce to_int and to_float which returns None when it can't parse a value.
  2. Remove all direct dictionary access, replaced by .get() and check for None.

How was the PR tested?

  1. Unit-test

Notes

patrickpa
patrickpa approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@patrickpa patrickpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoangtungdinh

@hoangtungdinh hoangtungdinh merged commit faa06e0 into develop Sep 13, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the tung/fix-condition branch September 13, 2024 07:43
hoangtungdinh added a commit that referenced this pull request Sep 25, 2024
@hoangtungdinh
Improve robustness in parsing numbers (#95)
3b0ff82 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Sep 25, 2024
Merged
hoangtungdinh added a commit that referenced this pull request Sep 25, 2024
@hoangtungdinh
Improve robustness in parsing numbers (#95)
bfd83d2 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
hoangtungdinh added a commit that referenced this pull request Oct 31, 2024
@hoangtungdinh
Improve robustness in parsing numbers (#95)
65a86f0 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickpa patrickpa patrickpa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangtungdinh @patrickpa