Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of coordinate transformation to other standards #292

Conversation

ClemensLinnhoff
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff commented Jan 13, 2025

Describe your changes

Add description of coordinate transformation to other standards.
Furthermore, I noticed that the reflectance table was still missing from the main introduction, so I quickly added it here, too.

Issue ticket number and link

Fixes #288

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator Author

@KimuraDIVP would these explanations answer your questions about the coordinate systems of other ASAM standards? Or is something missing?

@ktrmpc
Copy link

ktrmpc commented Jan 14, 2025

@KimuraDIVP would these explanations answer your questions about the coordinate systems of other ASAM standards? Or is something missing?

There is no shortage of information.
I think it would be very helpful if section 7.5.1.15.3 contained an explanation on how to convert the origin position to other ASAM standards (OpenSCENARIO, OSI, etc.).

@ClemensLinnhoff
Copy link
Collaborator Author

I think it would be very helpful if section 7.5.1.15.3 contained an explanation on how to convert the origin position to other ASAM standards (OpenSCENARIO, OSI, etc.).

I would not put explanations about coordinate transformation there, since this is just the json schema for the asset file. Furthermore, the axles are not needed for all conversions, e.g. to the OSI object coordinate frame. That's why I put the explanations to the coordinate systems chapter 7.2.2

Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed.
Signed-Off by: Diego Sánchez [email protected]

@ktrmpc
Copy link

ktrmpc commented Jan 14, 2025

I think it would be very helpful if section 7.5.1.15.3 contained an explanation on how to convert the origin position to other ASAM standards (OpenSCENARIO, OSI, etc.).

I would not put explanations about coordinate transformation there, since this is just the json schema for the asset file. Furthermore, the axles are not needed for all conversions, e.g. to the OSI object coordinate frame. That's why I put the explanations to the coordinate systems chapter 7.2.2

Thank you for your reply.
I understood the explanation in section 7.2.2. The contents of section 7.2.2 are very good, but to make it even better, I think that if the OpenMATERIAL3D definition is compatible with the ASAM standard, it will be widely used by users. Therefore, I thought it would be good to show that this schema can be used to easily convert the origin and coordinate system when OpenMATERIAL3D works with other ASAM standards. After reading this chapter, especially up to section 7.5.1.15.3, I thought that users might be worried about whether the origin is compatible with other standards.

Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator Author

ClemensLinnhoff commented Jan 15, 2025

Okay. I added a sentence in the axle description of the asset schema and I additionally added a link in the vehicle class general section.

@ktrmpc
Copy link

ktrmpc commented Jan 15, 2025

Okay. I added a sentence in the axle description of the asset schema and I additionally added a link in the vehicle class general section.

It has become easier to understand how to link to other ASAM standards. Thank you!

@ClemensLinnhoff ClemensLinnhoff merged commit 90b5ad4 into main Jan 15, 2025
3 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 288-explain-coordinate-transformations-to-other-asam-standards branch January 15, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain coordinate transformations to other ASAM standards
4 participants