[DO NOT MERGE] - Review app infinite disco #14881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavvia
reviewed
Nov 21, 2024
#1288 Bundle Size — 8.96MiB (+0.07%).d7c5860(current) vs 5ea69d4 main#1283(baseline) Warning Bundle contains 14 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1288 |
Baseline #1283 |
|
|---|---|---|
 Initial JS |
3.65MiB(+0.02%) |
3.65MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
45.58% |
39.32% |
| Chunks |
104(+0.97%) |
103 |
| Assets |
107(+0.94%) |
106 |
| Modules |
5836(+0.03%) |
5834 |
| Duplicate Modules |
530 |
530 |
| Duplicate Code |
4.03% |
4.03% |
| Packages |
266 |
266 |
| Duplicate Packages |
13 |
13 |
Bundle size by type 2 changes 2 regressions
| Current #1288 |
Baseline #1283 |
|
|---|---|---|
| JS |
8.81MiB (+0.05%) |
8.81MiB |
| Other |
144.68KiB (+0.92%) |
143.36KiB |
Bundle analysis report Branch review-app-infinite-disco Project dashboard
Generated by RelativeCI Documentation Report issue
egdbear
commented
Dec 11, 2024
package.json
Outdated
| @@ -147,6 +147,7 @@ | |||
| "lodash": "^4.17.21", | |||
| "luxon": "^3.2.1", | |||
| "map-cursor-to-max": "^1.0.0", | |||
| "mathjs": "^14.0.0", | |||
There was a problem hiding this comment.
this will be removed once we have query BE for open search on the metaphysics cc @nickskalkin
egdbear
force-pushed
the
review-app-infinite-disco
branch
from
36a4a39 to
f0fc4ec
Compare
|
Closing in favor of #14997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves [PROJECT-XX]
Description
https://infinite-disco.artsy.net/infinite-discovery
This PR is the POC of the Elastic Search recommendations.