Update requirements #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjusts docker-compose to align with hxat project
Make the requirements.txt more flexible, so other applications can more easily incorporate Catchpy.
3.12 was failing to install (pointing at old beta). Could move to a GHA matrix strategy instead of tox.
d-flood
approved these changes
May 29, 2024
README.rst
Outdated
Comment on lines
40
to
43
| $> docker compose up | ||
| $> docker compose exec web python manage.py migrate | ||
| $> docker compose exec web python manage.py createsuperuser | ||
| $> open http://localhost:8000/static/anno/index.html | ||
| $> docker-compose up | ||
| $> docker-compose exec web python manage.py migrate | ||
| $> docker-compose exec web python manage.py createsuperuser | ||
| $> open http://localhost:9000/static/anno/index.html |
There was a problem hiding this comment.
Looks like the legacy docker-compose command got put back in. I think Docker will soon stop shipping with the legacy command. It is not just syntax, docker-compose is a different CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR adds some upstream changes. It also makes the
requirements.txtdependencies more flexible, so that when Catchpy is installed as a package in an existing project it is less likely to throw dependency tree resolution errors.Related issue number
Related to DAR-422 (Upgrading MCH Python packages)
Checklist