Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to generating band light curves - get spectrum between timemin and timemax #217

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ccollins22
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #217 will not alter performance

Comparing lightcurvechanges (b65e404) with main (d7b9340)

Summary

✅ 24 untouched benchmarks

@ccollins22
Copy link
Member Author

When ruff adds strict it breaks the tests.

@ccollins22 ccollins22 requested a review from lukeshingles July 25, 2024 13:19
@lukeshingles
Copy link
Member

I'll review the code when it passes the checks, but in the mean time, could you update the title and description to explain what the PR is changing? I can maybe guess that you are reducing noise by widening the time bins of the band light curves? Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants