Create argument to display timestamps #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhwaniartefact
force-pushed
the
dev/issue-fixity-report-unsorted
branch
from
72a9c20 to
03ae867
Compare
replaceafill
requested changes
Jun 18, 2024
There was a problem hiding this comment.
@Dhwaniartefact It seems you still need to update the docs to include the new argument/flag.
Dhwaniartefact
force-pushed
the
dev/issue-fixity-report-unsorted
branch
from
11fe8fe to
1333731
Compare
replaceafill
requested changes
Jun 19, 2024
There was a problem hiding this comment.
@Dhwaniartefact I don't see any changes to the documentation as I pointed in the previous review?
Dhwaniartefact
force-pushed
the
dev/issue-fixity-report-unsorted
branch
from
b174684 to
4279dbd
Compare
The --timestamp option will display the date and time of the AIP fixity scan.
Dhwaniartefact
force-pushed
the
dev/issue-fixity-report-unsorted
branch
2 times, most recently
from
31a7109 to
dfd23c1
Compare
Dhwaniartefact
force-pushed
the
dev/issue-fixity-report-unsorted
branch
from
dfd23c1 to
f5b1d1a
Compare
replaceafill
approved these changes
Jun 21, 2024
docs/fixity.1
Outdated
| @@ -35,6 +35,10 @@ Request the Storage Service performs a local fixity check, instead of using the | |||
| \fB\-\-debug\fR | |||
| Print extra debugging output\. | |||
| . | |||
| .TP | |||
| \fB\-\-timestamps\fR | |||
| Add a timestamp to the beginning of each line of output.\. | |||
There was a problem hiding this comment.
Suggested change
| Add a timestamp to the beginning of each line of output.\. | |
| Add a timestamp to the beginning of each line of output\. |
docs/fixity.1.md
Outdated
Comment on lines
38
to
39
| * `--timestamps`: | ||
| It adds a timestamp to the beginning of each line of output. |
There was a problem hiding this comment.
Could we maintain the alignment on the other options?
Suggested change
| * `--timestamps`: | |
| It adds a timestamp to the beginning of each line of output. | |
| * `--timestamps`: | |
| It adds a timestamp to the beginning of each line of output. |
tests/test_fixity.py
Outdated
| @@ -74,6 +74,43 @@ def test_scan(_get, mock_check_fixity): | |||
| ] | |||
|
|
|||
|
|
|||
| @mock.patch("fixity.utils.utcnow") | |||
| @mock.patch("requests.get") | |||
| def test_scan_if_timestamps_is_True(_get, utcnow, mock_check_fixity, capsys): | |||
There was a problem hiding this comment.
Suggested change
| def test_scan_if_timestamps_is_True(_get, utcnow, mock_check_fixity, capsys): | |
| def test_scan_if_timestamps_argument_is_passed(_get, utcnow, mock_check_fixity, capsys): |
replaceafill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--timestampsoption will display the date and time of the AIP fixity scan.