Add tests for fixity.py #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
requested changes
Jun 6, 2024
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-for-fixity
branch
from
b8d8592 to
c8f996e
Compare
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-for-fixity
branch
from
d7f6982 to
b0df76a
Compare
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-for-fixity
branch
from
b0df76a to
5a1a7ab
Compare
replaceafill
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Thanks for the updates @Dhwaniartefact. I only see a couple of points letf:
- Removing the
calendardependency. I implemented an alternative way in this commit in case it helps, but feel free to design your own approach. - There's no scenarios testing a fixity check failure in the Storage Service. Is that worth adding?
replaceafill
approved these changes
Jun 7, 2024
|
@replaceafill : Thank you for your review and adding commits for removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.