Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature file for duplicate detection #103
add feature file for duplicate detection #103
Changes from 14 commits
c75f378
efde38e
1880375
f20e733
5798512
966f65f
03cbeef
319c889
c968398
b8f3ac7
e4a1298
27c83ba
743861b
ed8cfa8
53ed9d7
c20bda6
6936415
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavioral driven development asks about the what not the how. In this example, we don't want to rely on the mechanism
duplicates.py
because that script name might change. We should shorten this to:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is a second scenario, the first
Generate a duplicate report
, the secondDetect a true duplicate file
, this would look something like:And we can use a table to describe some rows of properties we need to validate.
It would be good to get clarification on which feature we're writing for - this current version looks like it could be tagged
@future
because I can see how it's where we might want to be. For IISH the feature is about generating the report so that the analysis can be done - I think it's the difference betweenGenerate a duplicates report
andGenerate a true duplicates report
.