Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test coverage of the create_mets_v2 script #2012

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Extend test coverage of the create_mets_v2 script #2012

merged 4 commits into from
Jan 9, 2025

Conversation

replaceafill
Copy link
Member

This adds type hints to the test_create_mets_v2.py script and extends the test coverage of the create_mets_v2 script.

The goal is to guarantee that an amdSec element is created from various types of metadata sources:

  • bag metadata
  • a transfer_metadata.xml metadata file
  • *.xml metadata files contained in sourceMD directories.

Connected to archivematica/Issues#1129

Dhwaniartefact
Dhwaniartefact approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@replaceafill replaceafill merged commit ab974d5 into qa/1.x Jan 9, 2025
22 checks passed
@replaceafill replaceafill deleted the dev/issue-1129-extend-test-coverage branch January 9, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhwaniartefact Dhwaniartefact Dhwaniartefact approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@replaceafill @Dhwaniartefact