Upgrade Frontend dependencies #1874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhwaniartefact
force-pushed
the
dev/issue-Update-fronend-dependecies-take-two
branch
from
7c3b21c to
8dd5d01
Compare
Dhwaniartefact
force-pushed
the
dev/issue-Update-fronend-dependecies-take-two
branch
from
8dd5d01 to
f179b83
Compare
Dhwaniartefact
added
AMAUAT
Dhwaniartefact
force-pushed
the
dev/issue-Update-fronend-dependecies-take-two
branch
from
f179b83 to
117181f
Compare
sevein
approved these changes
Nov 22, 2023
Comment on lines
+62
to
+64
| "webpack": { | ||
| "loader-utils": "1.4.2" | ||
| } |
There was a problem hiding this comment.
I didn't know overrides can do this, cool.
| @@ -51,25 +51,18 @@ RUN set -ex \ | |||
| && add-apt-repository --no-update --yes "deb http://archive.ubuntu.com/ubuntu/ jammy multiverse" \ | |||
| && add-apt-repository --no-update --yes "deb http://archive.ubuntu.com/ubuntu/ jammy-security universe" \ | |||
| && add-apt-repository --no-update --yes "deb http://archive.ubuntu.com/ubuntu/ jammy-updates multiverse" \ | |||
| && curl -sS https://deb.nodesource.com/setup_14.x | bash - \ | |||
There was a problem hiding this comment.
Can we use 18.x or 20.x? Related: https://endoflife.date/nodejs.
Comment on lines
+139
to
+140
| RUN set ex \ | ||
| && npm install -g [email protected] |
There was a problem hiding this comment.
Why 9.8.1 and not the latest 9.x, e.g. 9.9.2?
There was a problem hiding this comment.
Thank you and noted all your suggestions. I made changes accordingly in #1875
|
Closing this PR since npm and node are upgraded in #1875 |
Dhwaniartefact
deleted the
dev/issue-Update-fronend-dependecies-take-two
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend dependencies are upgraded by removing yarn packages and installing npm version 9.
overridesfeature of npm is used to upgrade specific version ofdevDependenciesanddependencies.Reference : https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides