fixing typo ISO8601 #1871
Closed
fixing typo ISO8601 #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to test rebuilding AM with the change included, but I failed at finding instructions on how to do this - following the hack instructions resulted in a Let me know if I need to do something? |
|
Oh my bad - I was in the wrong repo for Archivematica on my computer. |
Only the first item in the `chain_choices` and `replacements` arrays was being validated due to our usage of an array of schemas, leading to tuple validation. In this context, each position in the array was expected to validate against the schema at the corresponding position in the `items` array, leaving subsequent items unvalidated. This commit addresses this by converting `items` into a single schema object, ensuring that validation applies to all items within the array, not just the first.
This commit updates the workflow schema to no longer accept null values. Previously required fields that permitted nulls have been modified to become non-required. Excluding null as an acceptable value is a backward-incompatible change. However, as we have not committed to maintain backward compatibility, implementing this change is acceptable.
* Remove language version settings in pre-commit config * Remove flake8-import-order tox setting * Update tox configuration * Add flake8-bugbear * Add flake8-comprehensions
* Add make rules to manage AMAUATs Python deps * Update submodules * Update GitHub CI workflows * Upgrade pre-commit dependencies * Remove vcrpy
This fixes the `List Unapproved Transfers` and `List SIPS Waiting for User Input` API endpoints that were left behind after introducing the Django 3.2 `UUIDField`.
Closed
|
Closing in favor of #1872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to archivematica/Issues#348 for the 8061 -> 8601 typo.
I am not sure if there is a better way than to use a global variable in order to generalize the use_iso_8601 help text... Maybe we don't want to generalize it?
I don't mind making the individual changes if we decide this is the way to go.