Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the README #1870

Merged

Conversation

eviau-artefactual
Copy link
Contributor

@eviau-artefactual eviau-artefactual commented Nov 15, 2023

Hello!

A surprise PR with a few updates to the README for clarification, with the goal of helping contributors find the information they need.

View how it would look like in the end

Let me know what you think?

@eviau-artefactual
Copy link
Contributor Author

If you want to know: the picture for the repo was taken from the current website... Maybe we have another one, or maybe the logo would be best?

README.md Outdated Show resolved Hide resolved
@replaceafill
Copy link
Member

If you want to know: the picture for the repo was taken from the current website... Maybe we have another one, or maybe the logo would be best?

The logo would be my choice, but I'd like to hear @sromkey and @Dhwaniartefact opinion on this.

@sromkey
Copy link
Contributor

sromkey commented Nov 16, 2023

If you want to know: the picture for the repo was taken from the current website... Maybe we have another one, or maybe the logo would be best?

The logo would be my choice, but I'd like to hear @sromkey and @Dhwaniartefact opinion on this.

Sure, the logo sounds like a good choice!

@eviau-artefactual
Copy link
Contributor Author

My only constraint is having a logo with a background that is not transparent - or something else that makes it visible both on a dark theme and on a light theme... ?

@eviau-artefactual
Copy link
Contributor Author

Ready for second review - if it works for you we can add the logo in a potential other PR in the future :)

Copy link
Contributor

@sromkey sromkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @eviau-artefactual !

demo_s004.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in our meeting, maybe the screenshot should be removed because it's hard to keep up to date.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@eviau-artefactual eviau-artefactual merged commit 8557497 into artefactual:qa/1.x Aug 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants