Add small workflow schema improvements #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/workflow-remove-nulls
branch
3 times, most recently
from
a11eb4f to
8d57251
Compare
replaceafill
added
AMAUAT
sevein
force-pushed
the
dev/workflow-remove-nulls
branch
2 times, most recently
from
86066ee to
6110d79
Compare
sevein
added
the
AMAUAT
Only the first item in the `chain_choices` and `replacements` arrays was being validated due to our usage of an array of schemas, leading to tuple validation. In this context, each position in the array was expected to validate against the schema at the corresponding position in the `items` array, leaving subsequent items unvalidated. This commit addresses this by converting `items` into a single schema object, ensuring that validation applies to all items within the array, not just the first.
This commit updates the workflow schema to no longer accept null values. Previously required fields that permitted nulls have been modified to become non-required. Excluding null as an acceptable value is a backward-incompatible change. However, as we have not committed to maintain backward compatibility, implementing this change is acceptable.
sevein
force-pushed
the
dev/workflow-remove-nulls
branch
from
6110d79 to
a1ce480
Compare
replaceafill
added
AMAUAT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a couple of fixes to the workflow schema: