Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pytest-mock dependency #753

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove pytest-mock dependency #753

merged 1 commit into from
Oct 29, 2024

Conversation

replaceafill
Copy link
Member

pytest-mock provided value while we migrated from Python 2 to Python 3, but it's become less relevant now that the unittest.mock is included in the standard library. We also don't use any of its extra features like Spys or Stubs.

This replaces it with unittest.mock and removes the dependency from the requirements files.

@replaceafill replaceafill requested a review from a team October 26, 2024 03:42
@replaceafill replaceafill mentioned this pull request Oct 28, 2024
Merged
Dhwaniartefact
Dhwaniartefact approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@replaceafill replaceafill merged commit b3e3f4b into qa/0.x Oct 29, 2024
16 checks passed
@replaceafill replaceafill deleted the dev/remove-mocker branch October 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhwaniartefact Dhwaniartefact Dhwaniartefact approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@replaceafill @Dhwaniartefact