-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete create_testuser signal handler #364
Conversation
997ce2e
to
73033dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sevein Can you modify #286 to describe why this is a problem? Is it an issue of not wanting the default behaviour being creation of a superuser with a very guessable password?
Also, I'm wondering if your fixtures solution will still work if we update Django in the future. That is, does the hashed value of the "test" password change if Django uses a different hashing algorithm?
Finally, are you saying that merging this will require making mods in all of our deployment tools (ansible, packages, docker) so that they become responsible for creating this "test" user?
Done. I hope it's clearer now.
I'm using
I think that we're going to be solving this differently depending on the distribution type:
|
@jrwdunham one clarification: I think that artefactual/archivematica-docs#178 could be enough for now when it comes to explaining users how the installation process changes in debs/rpms/ansible without making actual changes in their sources. Perhaps @mamedin's effort to automate the installation via Ansible (see artefactual-labs/ansible-archivematica-src#162) may need some extra care once this is merged. IMO this PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
73033dd
to
2976d25
Compare
This commit removes the signal handler that was responsible for creating the
test
superuser. It is still possible to create a superuser from thecommand-line interface.
The
base
fixture file is updated so it includes a new superuser. Previously,the tests were relying on user created by the
create_testuser
signal handler.Connected to #286